Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in memory store should set last saved date #663

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

DavidBadura
Copy link
Member

The InMemoryStore implementation of the Subscription Store never set the last saved date.

@DavidBadura DavidBadura added the bug Something isn't working label Dec 30, 2024
@DavidBadura DavidBadura added this to the 3.6.1 milestone Dec 30, 2024
Copy link

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 951.800μs (±0.00%) | 996.200μs (±0.00%) | -4.46%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchLoad10000Events ()                | 47.841ms (±0.00%)  | 49.993ms (±0.00%)  | -4.30%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchSave1Event ()                     | 965.000μs (±0.00%) | 922.200μs (±0.00%) | +4.64%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 216.914ms (±0.00%) | 221.323ms (±0.00%) | -1.99%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.260s (±0.00%)    | 7.642s (±0.00%)    | -5.00%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.783s (±0.00%)    | 4.797s (±0.00%)    | -0.29%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 47.402ms (±0.00%)  | 47.835ms (±0.00%)  | -0.91%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 923.100μs (±0.00%) | 936.400μs (±0.00%) | -1.42%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 72.027ms (±0.00%) | 72.575ms (±0.00%) | -0.76%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.167s (±0.00%) | 3.157s (±0.00%) | +0.30%    | 46.382mb        | 46.382mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 906.900μs (±0.00%) | 910.900μs (±0.00%) | -0.44%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 84.996ms (±0.00%)  | 82.623ms (±0.00%)  | +2.87%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.454ms (±0.00%)   | 1.493ms (±0.00%)   | -2.60%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 246.597ms (±0.00%) | 247.011ms (±0.00%) | -0.17%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.457s (±0.00%)   | 11.383s (±0.00%)   | +0.65%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.905s (±0.00%)    | 8.919s (±0.00%)    | -0.16%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.036ms (±0.00%)   | 1.034ms (±0.00%)   | +0.23%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchLoad10000Events ()                | 57.541ms (±0.00%)  | 57.179ms (±0.00%)  | +0.63%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave1Event ()                     | 1.013ms (±0.00%)   | 977.300μs (±0.00%) | +3.63%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Events ()                | 295.027ms (±0.00%) | 291.280ms (±0.00%) | +1.29%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.548s (±0.00%)    | 7.530s (±0.00%)    | +0.24%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.994s (±0.00%)    | 4.996s (±0.00%)    | -0.05%    | 34.862mb        | 34.862mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.290ms (±0.00%)   | 4.261ms (±0.00%)   | +0.67%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 335.114ms (±0.00%) | 339.647ms (±0.00%) | -1.33%    | 37.145mb        | 37.145mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit d9a2790 into 3.6.x Dec 30, 2024
40 checks passed
@DanielBadura DanielBadura deleted the in-memory-store-should-set-updated-date branch December 30, 2024 12:31
@DavidBadura DavidBadura modified the milestones: 3.6.1, 3.6.2 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants