-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batch subscription #632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
force-pushed
the
batch-subscription
branch
3 times, most recently
from
September 20, 2024 17:37
a5cb728
to
3ae0fd0
Compare
DavidBadura
force-pushed
the
batch-subscription
branch
5 times, most recently
from
October 4, 2024 16:51
ea08a3a
to
0f6603d
Compare
DanielBadura
reviewed
Oct 7, 2024
DavidBadura
force-pushed
the
batch-subscription
branch
from
October 15, 2024 09:10
530d730
to
ca5e10c
Compare
DanielBadura
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows batching of events into the subscriber. This can provide significant performance benefits depending on how the user implements it. A new interface is added called
BatchableSubscriber
, which gives you several methods to control exactly what should happen. The subscriber engine then takes care of the rest.Here is an example: