Return empty topics on user settings check failures #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes less information. Otherwise, the user setting error is detectable.
|
@jkarlin PTAL. Thanks! |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 15, 2023
… disallowed by user settings This aligns with the handling for document.browsingTopics(), and will reveal less information. PR: patcg-individual-drafts/topics#276 Bug: 1502719 Change-Id: I2fba92cbf7af21613d2d0756c8318c4ea1ee4887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034182 Reviewed-by: Arthur Sonzogni <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Josh Karlin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1238153}
github-actions bot
added a commit
that referenced
this pull request
Jan 3, 2024
…-topics-on-user-setting-failure SHA: 73f85fa Reason: push, by jkarlin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to admariner/topics-API
that referenced
this pull request
Jan 3, 2024
…drafts/yao-return-empty-topics-on-user-setting-failure SHA: 73f85fa Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to wudi/topics
that referenced
this pull request
Jan 4, 2024
…drafts/yao-return-empty-topics-on-user-setting-failure SHA: 73f85fa Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to durangoe/topics
that referenced
this pull request
Jan 4, 2024
…drafts/yao-return-empty-topics-on-user-setting-failure SHA: 73f85fa Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
xyaoinum
deleted the
yao-return-empty-topics-on-user-setting-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes less information. Otherwise, the user setting error is detectable.
Drive-by: remove the mentioning of Chrome Origin Trial, as it has already ended.
Preview | Diff