Describe per-context limits in explainer #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcardle
commented
Jul 25, 2024
dmcardle
force-pushed
the
dmcardle-per-call-report-sizing
branch
from
337a822 to
c8a2d17
Compare
alexmturner
reviewed
Aug 2, 2024
There was a problem hiding this comment.
This PR depends on #138. (GitHub doesn't understand dependent PRs, so this appears to include its parent's changes.)
If your base branch is part of this repo, it is possible to mark the "base" branch of this PR as your other branch. Maybe I should work out how to give you the appropriate permissions...
This change is a little larger than it had to be, but I think it was time to add some structure to the section. WDYT, @alexmturner?
Added a few comments, thanks!
dmcardle
force-pushed
the
dmcardle-per-call-report-sizing
branch
from
c8a2d17 to
2633de8
Compare
|
Hey @alexmturner, PTAL again :) |
alexmturner
approved these changes
Sep 25, 2024
dmcardle
added a commit
to dmcardle/turtledove
that referenced
this pull request
Jan 8, 2025
dmcardle
added a commit
to dmcardle/turtledove
that referenced
this pull request
Jan 8, 2025
dmcardle
added a commit
to dmcardle/turtledove
that referenced
this pull request
Jan 8, 2025
dmcardle
added a commit
to dmcardle/shared-storage
that referenced
this pull request
Jan 9, 2025
The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report. To that end, this change adds the `maxContributions` field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters". Context: * Explainer: patcg-individual-drafts/private-aggregation-api#146 * Spec change: patcg-individual-drafts/private-aggregation-api#164
dmcardle
added a commit
to dmcardle/shared-storage
that referenced
this pull request
Jan 16, 2025
The goal is to enable Shared Storage embedders to override the default number of contributions per Private Aggregation report. To that end, this change adds the `maxContributions` field to the web-visible Private Aggregation config dictionary and plumbs its value into Private Aggregation's "pre-specified report parameters". Context: * Explainer: patcg-individual-drafts/private-aggregation-api#146 * Spec change: patcg-individual-drafts/private-aggregation-api#164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #138. (GitHub doesn't understand dependent PRs, so this appears to include its parent's changes.)This change is a little larger than it had to be, but I think it was time to add some structure to the section. WDYT, @alexmturner?