Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATS-5431 - Fix PHP 7.2 Drush issue https://github.com/drush-ops/drush/issues/3226 #1

Closed
wants to merge 1 commit into from

Conversation

fmiro
Copy link

@fmiro fmiro commented Jun 6, 2019

Fix PHP 7.2 Drush issue drush-ops/drush#3226

Use Console_Table 1.3.1 instead of Console_Table 1.1.5 that comes by default with drush 6.7.0 version.
At https://github.com/drush-ops/drush/blob/6.x/includes/environment.inc Console_Table 1.1.5 is downloaded dynamically if it does not already exist in lib folder. So we download 1.3.1 first and rename it to 1.1.5 as a "trick" to make it work without any other change

Use Console_Table 1.3.1 instead of Console_Table 1.1.5 that comes by default with drush 6.7.0 version.
At https://github.com/drush-ops/drush/blob/6.x/includes/environment.inc Console_Table 1.1.5 is downloaded dynamically if it does not already exist in lib folder. So we download 1.3.1 first and rename it to 1.1.5 as a "trick" to make it work without any other change
@fmiro
Copy link
Author

fmiro commented Jun 6, 2019

Tested with a local build. The warning does not appear anymore when running drush command

@pataquets pataquets closed this in 49f82d7 Jun 12, 2019
@pataquets
Copy link
Owner

Good catch, @fmiro. The fix works for me, thank you.
Digging a little in the code and issues you've referenced, I see that Drush can use Console_Table if it is available via PEAR install. I've just changed a bit the fix by using the pear binary to download and install the required package.
Basically, it's the same solution you provided, but instead of curl/extract manually the package, I leave it up to the pear installer binary. I've tested it and works as well.
I've pushed the fix. Thanks for the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants