Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a possibility to attach files #1

Merged
merged 10 commits into from
Sep 24, 2020
Merged

Add a possibility to attach files #1

merged 10 commits into from
Sep 24, 2020

Conversation

0x111
Copy link
Member

@0x111 0x111 commented Sep 14, 2020

Add a way to attach files.

Now you can attach one or more files (restrictions apply based on paste.me limits) to the paste while creating it.

Example usage:

pasteme-cli --name "My paste" --body "License file attached" --file ./LICENSE

If you would like to attach one or more files, you can call --file multiple times like this:

pasteme-cli --name "My paste" --body "License file attached" --file ./LICENSE --file README.md

0x111 added 2 commits June 5, 2020 16:15
- Adjust Makefile
- Add a way to attach files to a paste from the CLI
@0x111 0x111 added the enhancement New feature or request label Sep 14, 2020
@0x111 0x111 self-assigned this Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1 into master will decrease coverage by 5.04%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   88.28%   83.24%   -5.05%     
==========================================
  Files           1        1              
  Lines         128      179      +51     
==========================================
+ Hits          113      149      +36     
- Misses         10       19       +9     
- Partials        5       11       +6     
Impacted Files Coverage Δ
pasteme_cli.go 83.24% <84.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e109e80...0b6c4e3. Read the comment docs.

@0x111 0x111 merged commit 1d1fa03 into master Sep 24, 2020
@0x111
Copy link
Member Author

0x111 commented Sep 24, 2020

Test coverage is fair enough, it does cover all major functions including the uploading of files is being tested too. So I think the coverage is good at the moment that is why I will accept this as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant