Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override package install timeout from 30 seconds to 120 seconds #596

Open
wants to merge 1 commit into
base: bundlephobia
Choose a base branch
from

Conversation

n10l
Copy link

@n10l n10l commented Dec 26, 2021

Fixes for me #595

@n10l
Copy link
Author

n10l commented Jun 16, 2022

@pastelsky @Harry-Hopkinson Could you please merge this?

@pastelsky
Copy link
Owner

pastelsky commented Jun 16, 2022

Why does the package take more than 30 seconds to install though? The reason for the 30s timeout is to protect bundlephobia against resource exhaustion caused by a few packages.

If it takes up to 120 seconds to install a single package on a fast (AWS-level) internet connection, I'd argue that it isn't the best experience for users of the package, and bundlephobia definitely isn't meant to process every package on npm.

@n10l
Copy link
Author

n10l commented Jun 16, 2022

@pastelsky Could be due to rollup-plugin-scss which might be causing this while installing node-sass/sass, which I guess compiles on local machine while installation. I am no more working on same thing currently. But when I resume, I will check. But, as few other people were facing this as well #623 I requested for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants