-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promises #21
base: master
Are you sure you want to change the base?
Promises #21
Commits on Sep 11, 2019
-
- Breaking change: Stop supporting older behavior against layers of a…
…rity one or two (will now drop one with no `done`) - Breaking change: We now catch errors within layers so as to support more intuitive passing of errors (when synchronous) - Breaking change: No longer throws when login is missing a callback (as may use as Promise) - Breaking change: Only return from `serializeUser`, `deserializeUser` (and `transformAuthInfo`) when giving a synchronous serialized result or a Promise (do not do `return done()`) - Enhancement: Promises for `serializeUser`, `deserializeUser`, `transformAuthInfo` (including allowing throwing `new Error('pass')` to pass); avoid need for `done` - Enhancement: Allow `serializeUser` or `deserializeUser` to return non-`undefined` value for sync behavior - Refactoring: Return Promise from `req.logIn` and from authenticate middleware's `strategy.success` - Testing: Add tests with `req.logIn` and `SessionStrategy` returning without `done` (synchronously or with Promise) - Docs: Show example of a `LocalStrategy` using async/await - Docs: Avoid showing connect `cookieParser` with `session`; use current `expressSession` over `connect.session` - Linting: jsdoc - Git: Ignore .github/docs/jsdoc - npm/Docs: Add jsdoc with script, along with static server and open-cli to open - npm: Add `test-one` script; remove self from contributors
Configuration menu - View commit details
-
Copy full SHA for 31dea32 - Browse repository at this point
Copy the full SHA 31dea32View commit details -
- Linting (ESLint): Avoid "useless" catch error; adhere to stricter j…
…sdoc context checking - Minor fixes for template files for gitignore/package.json/README
Configuration menu - View commit details
-
Copy full SHA for fb9d5b0 - Browse repository at this point
Copy the full SHA fb9d5b0View commit details -
- Docs: more precise jsdoc - Update sessionmanager test per Promises API - Fix template
Configuration menu - View commit details
-
Copy full SHA for 2215b0b - Browse repository at this point
Copy the full SHA 2215b0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f763a0e - Browse repository at this point
Copy the full SHA f763a0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b99cc5 - Browse repository at this point
Copy the full SHA 4b99cc5View commit details
Commits on Sep 12, 2019
-
- Refactoring: Avoid
let
in unneeded higher scope- Testing: Rename strategy name to distinguish from `fail` method - Testing: Expand coverage (incomplete)
Configuration menu - View commit details
-
Copy full SHA for 6505c94 - Browse repository at this point
Copy the full SHA 6505c94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 445a673 - Browse repository at this point
Copy the full SHA 445a673View commit details -
- Testing: Delete
_passport
object when simulating without `initial……ize` (as it is added there)
Configuration menu - View commit details
-
Copy full SHA for 357727a - Browse repository at this point
Copy the full SHA 357727aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c220b5b - Browse repository at this point
Copy the full SHA c220b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee8ac43 - Browse repository at this point
Copy the full SHA ee8ac43View commit details -
- Testing: For login test now, delete
_passport
object when simulat……ing without `initialize` (as it is added there)
Configuration menu - View commit details
-
Copy full SHA for 504f7b1 - Browse repository at this point
Copy the full SHA 504f7b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3026221 - Browse repository at this point
Copy the full SHA 3026221View commit details -
- Fix: Returning
undefined
to continue promise chain- Testing: Add tests for `serializeUser`/`deserializeUser`/`transformAuthInfo` that return `undefined` - Testing: Fix serializeUser/deserializeUser to error (with only one `undefined`-returning callback)
Configuration menu - View commit details
-
Copy full SHA for 017745f - Browse repository at this point
Copy the full SHA 017745fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45502ba - Browse repository at this point
Copy the full SHA 45502baView commit details -
Configuration menu - View commit details
-
Copy full SHA for e45b79e - Browse repository at this point
Copy the full SHA e45b79eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce4b40a - Browse repository at this point
Copy the full SHA ce4b40aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3fd8e1 - Browse repository at this point
Copy the full SHA b3fd8e1View commit details
Commits on Sep 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dbf7c51 - Browse repository at this point
Copy the full SHA dbf7c51View commit details -
- Linting (ESLint): Apply to any HTML files; confine overrides to tes…
…t files; avoid nested branch
Configuration menu - View commit details
-
Copy full SHA for cb38add - Browse repository at this point
Copy the full SHA cb38addView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36fb361 - Browse repository at this point
Copy the full SHA 36fb361View commit details
Commits on Sep 16, 2019
-
- Linting: Add chai-friendly plugin to avoid need for disabling `no-u…
…nused-expressions` for chai assertions
Configuration menu - View commit details
-
Copy full SHA for 786d028 - Browse repository at this point
Copy the full SHA 786d028View commit details
Commits on Sep 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4a347da - Browse repository at this point
Copy the full SHA 4a347daView commit details
Commits on Jan 13, 2020
-
- INCOMPLETE (need to get PR for ash-nazg upgraded and switch back to…
… passport-next version once merged - Linting (ESLint): Update per latest ash-nazg - Maintenance: Add `.editorconfig` - npm: Update devDeps (coveralls, linting, mocha, nyc)
Configuration menu - View commit details
-
Copy full SHA for e67601d - Browse repository at this point
Copy the full SHA e67601dView commit details
Commits on Jul 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 92127f6 - Browse repository at this point
Copy the full SHA 92127f6View commit details -
Merge commit 'ad4f18ab7d55952612f081caa054a768f288971e' into promises
* commit 'ad4f18ab7d55952612f081caa054a768f288971e': Updated npm deps Updated skel Updated funding.yml Added FUNDING.yml any other devs feel free to add yourself v3.1.0 Updated npm deps Feature: Pass instantiated strategy to authenticate. # Conflicts: # lib/middleware/authenticate.js # package-lock.json # package.json # templates/package.json.j2
Configuration menu - View commit details
-
Copy full SHA for 10a72c6 - Browse repository at this point
Copy the full SHA 10a72c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14dbfd2 - Browse repository at this point
Copy the full SHA 14dbfd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d0338 - Browse repository at this point
Copy the full SHA e7d0338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14aacbc - Browse repository at this point
Copy the full SHA 14aacbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef547ce - Browse repository at this point
Copy the full SHA ef547ceView commit details
Commits on Feb 2, 2021
-
Merge branch 'master' into promises
* master: Updated travis node versions # Conflicts: # .travis.yml
Configuration menu - View commit details
-
Copy full SHA for a568183 - Browse repository at this point
Copy the full SHA a568183View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d7883b - Browse repository at this point
Copy the full SHA 6d7883bView commit details
Commits on Feb 14, 2021
-
- npm: Move vulnerable node-static server to http-server
- npm: Update devDeps (including swapping eslint-config-ash-nazg peerDep. and drop need for typescript)
Configuration menu - View commit details
-
Copy full SHA for 455e3e0 - Browse repository at this point
Copy the full SHA 455e3e0View commit details
Commits on Feb 17, 2021
-
- Linting: Use ESLint 7 new processor API as now targeted by `eslint-…
…plugin-markdown` and `eslint-plugin-jsdoc` - npm: Update devDeps.
Configuration menu - View commit details
-
Copy full SHA for 901cc0b - Browse repository at this point
Copy the full SHA 901cc0bView commit details
Commits on Jul 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 32f0c0f - Browse repository at this point
Copy the full SHA 32f0c0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58066c9 - Browse repository at this point
Copy the full SHA 58066c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf5b846 - Browse repository at this point
Copy the full SHA cf5b846View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29fee11 - Browse repository at this point
Copy the full SHA 29fee11View commit details