Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises #21

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Promises #21

wants to merge 37 commits into from

Commits on Sep 11, 2019

  1. - Breaking change: Stop supporting older behavior against layers of a…

    …rity one or two
    
        (will now drop one with no `done`)
    - Breaking change: We now catch errors within layers so as to support more
        intuitive passing of errors (when synchronous)
    - Breaking change: No longer throws when login is missing a callback (as may use as Promise)
    - Breaking change: Only return from `serializeUser`, `deserializeUser` (and `transformAuthInfo`)
        when giving a synchronous serialized result or a Promise (do not do `return done()`)
    - Enhancement: Promises for `serializeUser`, `deserializeUser`, `transformAuthInfo`
        (including allowing throwing `new Error('pass')` to pass); avoid need for `done`
    - Enhancement: Allow `serializeUser` or `deserializeUser` to return non-`undefined`
        value for sync behavior
    - Refactoring: Return Promise from `req.logIn` and from authenticate middleware's
        `strategy.success`
    - Testing: Add tests with `req.logIn` and `SessionStrategy` returning without `done`
        (synchronously or with Promise)
    - Docs: Show example of a `LocalStrategy` using async/await
    - Docs: Avoid showing connect `cookieParser` with `session`;
        use current `expressSession` over `connect.session`
    - Linting: jsdoc
    - Git: Ignore .github/docs/jsdoc
    - npm/Docs: Add jsdoc with script, along with static server and open-cli to open
    - npm: Add `test-one` script; remove self from contributors
    brettz9 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    31dea32 View commit details
    Browse the repository at this point in the history
  2. - Linting (ESLint): Avoid "useless" catch error; adhere to stricter j…

    …sdoc context checking
    
    - Minor fixes for template files for gitignore/package.json/README
    brettz9 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    fb9d5b0 View commit details
    Browse the repository at this point in the history
  3. - Linting: example whitespace

    - Docs: more precise jsdoc
    - Update sessionmanager test per Promises API
    - Fix template
    brettz9 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    2215b0b View commit details
    Browse the repository at this point in the history
  4. - npm: Update devDeps

    brettz9 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    f763a0e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4b99cc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. - Refactoring: Avoid let in unneeded higher scope

    - Testing: Rename strategy name to distinguish from `fail` method
    - Testing: Expand coverage (incomplete)
    brettz9 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    6505c94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    445a673 View commit details
    Browse the repository at this point in the history
  3. - Testing: Delete _passport object when simulating without `initial…

    …ize` (as it is added there)
    brettz9 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    357727a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c220b5b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ee8ac43 View commit details
    Browse the repository at this point in the history
  6. - Testing: For login test now, delete _passport object when simulat…

    …ing without `initialize` (as it is added there)
    brettz9 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    504f7b1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3026221 View commit details
    Browse the repository at this point in the history
  8. - Fix: Returning undefined to continue promise chain

    - Testing: Add tests for `serializeUser`/`deserializeUser`/`transformAuthInfo` that return `undefined`
    - Testing: Fix serializeUser/deserializeUser to error (with only one `undefined`-returning callback)
    brettz9 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    017745f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    45502ba View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e45b79e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ce4b40a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b3fd8e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Configuration menu
    Copy the full SHA
    dbf7c51 View commit details
    Browse the repository at this point in the history
  2. - Linting (ESLint): Apply to any HTML files; confine overrides to tes…

    …t files; avoid nested branch
    brettz9 committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    cb38add View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    36fb361 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. - Linting: Add chai-friendly plugin to avoid need for disabling `no-u…

    …nused-expressions` for chai assertions
    brettz9 committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    786d028 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Configuration menu
    Copy the full SHA
    4a347da View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. - INCOMPLETE (need to get PR for ash-nazg upgraded and switch back to…

    … passport-next version once merged
    
    - Linting (ESLint): Update per latest ash-nazg
    - Maintenance: Add `.editorconfig`
    - npm: Update devDeps (coveralls, linting, mocha, nyc)
    brettz9 committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    e67601d View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Configuration menu
    Copy the full SHA
    92127f6 View commit details
    Browse the repository at this point in the history
  2. Merge commit 'ad4f18ab7d55952612f081caa054a768f288971e' into promises

    * commit 'ad4f18ab7d55952612f081caa054a768f288971e':
      Updated npm deps
      Updated skel
      Updated funding.yml
      Added FUNDING.yml any other devs feel free to add yourself
      v3.1.0
      Updated npm deps
      Feature: Pass instantiated strategy to authenticate.
    
    # Conflicts:
    #	lib/middleware/authenticate.js
    #	package-lock.json
    #	package.json
    #	templates/package.json.j2
    brettz9 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    10a72c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    14dbfd2 View commit details
    Browse the repository at this point in the history
  4. - npm: Update lock file

    brettz9 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    e7d0338 View commit details
    Browse the repository at this point in the history
  5. - npm: Update template

    brettz9 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    14aacbc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ef547ce View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Merge branch 'master' into promises

    * master:
      Updated travis node versions
    
    # Conflicts:
    #	.travis.yml
    brettz9 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    a568183 View commit details
    Browse the repository at this point in the history
  2. - npm: Update template variables

    - npm: Update devDeps
    brettz9 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    6d7883b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. - npm: Move vulnerable node-static server to http-server

    - npm: Update devDeps (including swapping eslint-config-ash-nazg peerDep. and drop need for typescript)
    brettz9 committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    455e3e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. - Linting: Use ESLint 7 new processor API as now targeted by `eslint-…

    …plugin-markdown` and `eslint-plugin-jsdoc`
    
    - npm: Update devDeps.
    brettz9 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    901cc0b View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. - Linting: As per latest ash-nazg

    - npm: Update devDeps.
    brettz9 committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    32f0c0f View commit details
    Browse the repository at this point in the history
  2. - Breaking change: Drop Node 10

    - Testing Check Node 16
    brettz9 committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    58066c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cf5b846 View commit details
    Browse the repository at this point in the history
  4. - Docs: Fix JSDoc values

    brettz9 committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    29fee11 View commit details
    Browse the repository at this point in the history