Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

Make EKU optional #64

Merged
merged 5 commits into from
Feb 25, 2019
Merged

Make EKU optional #64

merged 5 commits into from
Feb 25, 2019

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Feb 23, 2019

Currently it's enforced, rather enable it (or not) based e.g. on remote-cert-tls server in .ovpn configuration file. Gives more interoperability with some reported scenarios where the user may not be in full control of server settings.

@keeshux keeshux added the enhancement New feature or request label Feb 23, 2019
@keeshux keeshux added this to the 1.4.1 milestone Feb 23, 2019
@keeshux keeshux self-assigned this Feb 23, 2019
@ghost
Copy link

ghost commented Feb 25, 2019

Be aware that if EKUs are NOT used by the CA of the VPN provider, that there MUST be another way to make sure the peer certificate is a VPN server certificate, otherwise any client with a certificate from the same VPN provider can MITM the traffic of any other VPN client...

@keeshux
Copy link
Member Author

keeshux commented Feb 25, 2019

@fkooman you either enable SessionProxy.ConfigurationBuilder.checksEKU or remote-cert-tls server in the .ovpn -like you're normally supposed to do- and you're done.

@ghost
Copy link

ghost commented Feb 25, 2019

Fair enough :)

@keeshux keeshux merged commit 3ee257b into master Feb 25, 2019
@keeshux keeshux deleted the make-eku-optional branch February 25, 2019 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant