This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Revert to OpenSSL #233
Merged
Revert to OpenSSL #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bitcode disabled has a weird effect on the client app in development mode:
The opposite happens in distribution (TestFlight), app crashes when Bitcode is enabled. It's more likely that his has to do with https://github.com/keeshux/openssl-apple/ |
- Runs from Xcode - Crashes from device
|
Crashes were fixed by using an OpenSSL binary with Bitcode completely disabled. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some subtle differences with BoringSSL, very hard to address.
Fixes #230, fixes #232