Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32679)[API] chore: Rename offerer endpoint #15848

Merged

Conversation

dramelet-pass
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32679

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

@dramelet-pass dramelet-pass force-pushed the dramelet/PC-32679-rename-get-offerer-address-endpoint branch from f1c0b7f to edffbd9 Compare January 14, 2025 10:33
@dramelet-pass dramelet-pass changed the title (BSR)[API] chore: Remove unused endpoint (PC-32679)[API] chore: Rename offerer endpoint Jan 14, 2025
@dramelet-pass dramelet-pass force-pushed the dramelet/PC-32679-rename-get-offerer-address-endpoint branch from edffbd9 to 9c494d8 Compare January 14, 2025 10:51
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Visit the preview URL for this PR (updated for commit ac89007):

https://pc-pro-testing--pr15848-dramelet-pc-32679-re-pr4p476s.web.app

(expires Thu, 16 Jan 2025 15:11:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@dramelet-pass dramelet-pass force-pushed the dramelet/PC-32679-rename-get-offerer-address-endpoint branch from 9c494d8 to b769c13 Compare January 14, 2025 13:35
to `offerer/{offerer_id}/offerer_addresses`. It's more
consistants with ressources returned by this endpoint
@dramelet-pass dramelet-pass force-pushed the dramelet/PC-32679-rename-get-offerer-address-endpoint branch from b769c13 to ac89007 Compare January 14, 2025 15:01
Copy link
Contributor

@lmaubert-pass lmaubert-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi =)

@dramelet-pass dramelet-pass merged commit 538dbe1 into master Jan 15, 2025
31 checks passed
@dramelet-pass dramelet-pass deleted the dramelet/PC-32679-rename-get-offerer-address-endpoint branch January 15, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants