PC-33636 add chronicles to offer route #15839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e31d2e3): https://pc-pro-testing--pr15839-pc-33636-add-chronic-bmxau8uu.web.app (expires Wed, 15 Jan 2025 17:42:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
cnormant-pass
force-pushed
the
pc-33636-add-chronicles-to-offer-route
branch
from
23e2940 to
e31d2e3
Compare
cnormant-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
tconte-pass
reviewed
Jan 15, 2025
Comment on lines
+348
to
+350
| first_name: str | None | ||
| age: int | None | ||
| city: str | None |
There was a problem hiding this comment.
On peut enlever les | None ici non ?
There was a problem hiding this comment.
Hmm non potentiellement on aura l'un mais pas les autres
Le formulaire est souple
(de ce que j'ai compris)
tconte-pass
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33636
Vérifications