Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33424)[API] feat: set headline offer to inactive when it has no image #15836

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ogeber-pass
Copy link
Contributor

@ogeber-pass ogeber-pass commented Jan 13, 2025

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33424

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

Copy link
Contributor

github-actions bot commented Jan 13, 2025

mypy cop report: 458 (master) ↗ 459 (your branch)

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Visit the preview URL for this PR (updated for commit cf1355e):

https://pc-pro-testing--pr15836-ogeber-pc-33424-remo-xe5x1k4u.web.app

(expires Wed, 15 Jan 2025 17:06:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@ogeber-pass ogeber-pass changed the title Ogeber/pc 33424 remove headline offer if offer has no mediations (PC-33424)[API] feat: set headline offer to inactive when it has no image Jan 13, 2025
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33424-remove-headline-offer-if-offer-has-no-mediations branch from f96d0e9 to 65f24b6 Compare January 13, 2025 16:40
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33424-remove-headline-offer-if-offer-has-no-mediations branch from 65f24b6 to cf1355e Compare January 13, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant