(PC-33676)[PRO] fix: Dont set all opening hours to closed when editin… #15825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclery-pass
approved these changes
Jan 13, 2025
gmeigniez-pass
force-pushed
the
pc-33676-opening-hours-edit
branch
from
1c5a479 to
db84d37
Compare
pro/src/pages/VenueEdition/OpeningHoursForm/OpeningHoursForm.tsx
Outdated
Show resolved
Hide resolved
abouabdallaoui-pass
approved these changes
Jan 13, 2025
gmeigniez-pass
force-pushed
the
pc-33676-opening-hours-edit
branch
from
db84d37 to
8c2a366
Compare
|
Visit the preview URL for this PR (updated for commit f599036): https://pc-pro-testing--pr15825-pc-33676-opening-hou-gdetchsf.web.app (expires Wed, 15 Jan 2025 15:32:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
…g a venue with no opening hours.
gmeigniez-pass
force-pushed
the
pc-33676-opening-hours-edit
branch
from
8c2a366 to
f599036
Compare
abouabdallaoui-pass
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g a venue with no opening hours.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33676
Objectif
Ne pas envoyer des openingHours avec des jours sans valeur d'ouverture quand on met à jour une venue qui n'a pas encore d'openingHour.
L'api des heures d'ouverture a pas été prévue pour gérer la différence entre "fermé" et "horaires d'ouverture non renseignées" lors d'une modif du lieu (on ne peut pas PATCH avec des valeurs d'ouverture
null). L'api est à revoir, cette PR est juste un petit hack pour qu'au moins on ne set pas systématiquement les heures d'ouverture à "fermé" quand on update qqchose dans le lieu.Vérifications