(PC-33809)[PRO] style: eslint config fix / clean + restore no unused rule & remove dead code #15734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2943803): https://pc-pro-testing--pr15734-pc-33809-eslint-fix-cy18qfju.web.app (expires Thu, 09 Jan 2025 17:11:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
mleroy-pass
reviewed
Jan 7, 2025
mleroy-pass
approved these changes
Jan 7, 2025
…plicate ts checks
… eslint.config.mjs
asaez-pass
force-pushed
the
PC-33809-eslint-fix-and-no-unused-code
branch
from
dba020e to
2943803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33809
Vérifications
J'ai écrit les tests nécessairesJ'ai mis à jour le fichier des plans de tests du portail pro si nécessaireJ'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et DataJ'ai ajouté des screenshots pour d'éventuels changements graphiquesJ'ai fait la revue fonctionnelle de mon ticket