Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33346)[API] feat: add create and delete headline offer routes #15715

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ogeber-pass
Copy link
Contributor

@ogeber-pass ogeber-pass commented Jan 3, 2025

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33346

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch from 3236223 to ba6e1de Compare January 3, 2025 16:46
Copy link
Contributor

github-actions bot commented Jan 3, 2025

mypy cop report: 466 (master) = 466 (your branch)

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Visit the preview URL for this PR (updated for commit ebcd1a0):

https://pc-pro-testing--pr15715-ogeber-pc-33726-rout-97c13bn1.web.app

(expires Thu, 09 Jan 2025 17:26:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@ogeber-pass ogeber-pass marked this pull request as ready for review January 6, 2025 08:07
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33423-add-status-to-headline-offer branch from 0b97ef6 to a8aff54 Compare January 6, 2025 08:21
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch from ba6e1de to 131cd42 Compare January 6, 2025 09:30
@ogeber-pass ogeber-pass changed the title (PC-33726)[API] feat: add create and delete headline offer routes (PC-33346)[API] feat: add create and delete headline offer routes Jan 6, 2025
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33423-add-status-to-headline-offer branch from a8aff54 to 32027e1 Compare January 6, 2025 09:31
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch from 131cd42 to 31833ed Compare January 6, 2025 09:35
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33423-add-status-to-headline-offer branch from 32027e1 to 72c30fb Compare January 6, 2025 13:11
Base automatically changed from ogeber/pc-33423-add-status-to-headline-offer to master January 6, 2025 13:36
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch from 31833ed to 38d6f40 Compare January 6, 2025 13:36
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch from 38d6f40 to 94cc5f2 Compare January 6, 2025 13:55
api/src/pcapi/routes/pro/headline_offer.py Outdated Show resolved Hide resolved
api/src/pcapi/routes/pro/headline_offer.py Outdated Show resolved Hide resolved
api/src/pcapi/routes/pro/headline_offer.py Outdated Show resolved Hide resolved
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch 2 times, most recently from 1877172 to 4a3e03c Compare January 7, 2025 16:48
@ogeber-pass ogeber-pass force-pushed the ogeber/pc-33726-route-to-upsert-headline-offer branch from 4a3e03c to ebcd1a0 Compare January 7, 2025 17:15
@ogeber-pass ogeber-pass merged commit efd7a74 into master Jan 8, 2025
30 checks passed
@ogeber-pass ogeber-pass deleted the ogeber/pc-33726-route-to-upsert-headline-offer branch January 8, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants