Pc 33527 checkbox group with border #15709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 806d693): https://pc-pro-testing--pr15709-pc-33527-checkbox-gr-btyipcps.web.app (expires Wed, 15 Jan 2025 10:31:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
jclery-pass
reviewed
Jan 3, 2025
pro/src/ui-kit/form/shared/BaseCheckbox/BaseCheckbox.module.scss
Outdated
Show resolved
Hide resolved
gmeigniez-pass
force-pushed
the
pc-33527-checkbox-group-with-border
branch
from
681b6f7 to
f527c70
Compare
jclery-pass
approved these changes
Jan 3, 2025
abouabdallaoui-pass
approved these changes
Jan 7, 2025
gmeigniez-pass
force-pushed
the
pc-33527-checkbox-group-with-border
branch
from
f527c70 to
bcdfebd
Compare
gmeigniez-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
ahello-pass
force-pushed
the
pc-33527-checkbox-group-with-border
branch
from
bcdfebd to
259f128
Compare
ahello-pass
force-pushed
the
pc-33527-checkbox-group-with-border
branch
from
259f128 to
e8d808a
Compare
ahello-pass
force-pushed
the
pc-33527-checkbox-group-with-border
branch
from
e8d808a to
806d693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33527
Objectif
Comme pour les radio group, avoir le variant des checkbox avec bordure, et potentiellement inline, et pouvoir afficher du contenu sous la checkbox quand elle est cochée.
C'est dans le cadre de l'amélioration des offres vitrines côté collectif. Les différents écrans qu'on doit pouvoir développer à terme sont ici, cependant, cette PR ne concerne que le travail sur les checkbox elles-mêmes et pas l'implémentation.
Vérifications