Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33758) fix pr env deployments #15699

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

lgerard-pass
Copy link
Contributor

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33758

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

@lgerard-pass lgerard-pass requested review from a team as code owners January 2, 2025 16:04
@lgerard-pass lgerard-pass self-assigned this Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Visit the preview URL for this PR (updated for commit c5022f0):

https://pc-pro-testing--pr15699-pc-33758-fix-deploym-dxg5bdud.web.app

(expires Fri, 10 Jan 2025 15:46:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch 7 times, most recently from 28a3ceb to 263f6ab Compare January 3, 2025 15:54
Copy link
Contributor

github-actions bot commented Jan 3, 2025

mypy cop report: 466 (master) = 466 (your branch)

@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch from f251985 to cf15ea5 Compare January 3, 2025 16:43
@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch from cf15ea5 to 32d0f02 Compare January 6, 2025 10:25
@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch from 32d0f02 to 584e6d4 Compare January 6, 2025 10:55
@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch from 584e6d4 to d1d8ee1 Compare January 6, 2025 13:11
@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch from 96b9357 to bdb2d9f Compare January 6, 2025 14:48
@lgerard-pass lgerard-pass force-pushed the PC-33758-fix-deployments branch 2 times, most recently from 2c6734e to ab97fab Compare January 8, 2025 09:28
@lgerard-pass lgerard-pass merged commit e4ce69e into master Jan 9, 2025
18 checks passed
@lgerard-pass lgerard-pass deleted the PC-33758-fix-deployments branch January 9, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants