(PC-33528)[PRO] feat : add new Multiselect component #15628
+1,469
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahello-pass
temporarily deployed
to
pullrequest
GitHub Actions
Inactive
ahello-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
from
e4f34d2 to
a6935c0
Compare
mleroy-pass
temporarily deployed
to
pullrequest
GitHub Actions
Inactive
mleroy-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
3 times, most recently
from
96161cf to
d83f8ac
Compare
mleroy-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
4 times, most recently
from
a38d613 to
51e3823
Compare
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
3 times, most recently
from
bf5e2e9 to
4c43813
Compare
There was a problem hiding this comment.
Ca rend super bien 🎉
J'ai quelques petits retours d'utilisation et d'a11y, mais l'affichage visuel / fonctionnement souris m'ont l'air nickel :
- Quand on est focus sur le bouton, je m'attends à ce que le panneau s'ouvre automatiquement quand je presse "Enter" ou "Space"
- Il faut que le panneau se ferme quand le focus sort du panneau (sinon il risque de cacher du contenu inutilement)
- Quand on est focus sur l'input de la checkbox c'est la touche "Space" qui doit toggle la sélection et pas la touche "Enter" (la doc du pattern est ici), ça fonctionne bien pour le "Tout sélectionner", mais pas pour les checkbox individuelles
- Il faudrait un attribut
aria-controlssur le bouton d'ouverture avec pour valeur l'id de la div du panneau (idéalement il faudrait que l'attribut controls apparaisse quand la div du paneau apparait pour ne pas avoir une référence à un id inexistant) - Au moment de faire une recherche dans l'input de recherche, il faudrait un moyen d'annoncer (et d'afficher p-être ?) le nombre de résultats (souvent via un
role="status"sur un texte genre "n résultats")
Ce serait cool d'avoir l'avis de Julie au global sur le composant (en particulier au lecteur d'écran)!
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
from
4c43813 to
e84a161
Compare
|
Visit the preview URL for this PR (updated for commit e998578): https://pc-pro-testing--pr15628-pc-33528-new-multi-s-wlndeqgo.web.app (expires Thu, 16 Jan 2025 10:35:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
9 times, most recently
from
e1b3605 to
c412b65
Compare
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
from
c412b65 to
c80fc3d
Compare
mleroy-pass
force-pushed
the
pc-33528-new-multi-selector-component
branch
from
c80fc3d to
e998578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33528
Vérifications