-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-33377)[API] chore: Remove useless POST venues
route
#15390
Open
dramelet-pass
wants to merge
4
commits into
master
Choose a base branch
from
dramelet/PC-33377-handle-manual-edition-while-creating-venue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
(PC-33377)[API] chore: Remove useless POST venues
route
#15390
dramelet-pass
wants to merge
4
commits into
master
from
dramelet/PC-33377-handle-manual-edition-while-creating-venue
+127
−1,690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
December 5, 2024 17:15
25ab840
to
ac63194
Compare
Visit the preview URL for this PR (updated for commit d63b333): https://pc-pro-testing--pr15390-dramelet-pc-33377-ha-7r0nfe33.web.app (expires Sun, 12 Jan 2025 16:41:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
December 6, 2024 10:09
ac63194
to
7682678
Compare
mypy cop report: 458 (master) ↘ 457 (your branch) Have yourself a merry little break and learn a few facts about the year 457. |
xordoquy-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
December 16, 2024 14:43
7682678
to
b961733
Compare
xordoquy-pass
temporarily deployed
to
pullrequest
December 16, 2024 15:00 — with
GitHub Actions
Inactive
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 3, 2025 07:59
b961733
to
02031c6
Compare
dramelet-pass
changed the title
(PC-33377)[API] feat: Handle manual edition while creating venue
(PC-32880)[API] feat: Handle manual edition while creating venue
Jan 6, 2025
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 6, 2025 16:28
1fb05c8
to
39c468a
Compare
dramelet-pass
changed the title
(PC-32880)[API] feat: Handle manual edition while creating venue
(PC-33377)[API] feat: Handle manual edition while creating venue
Jan 6, 2025
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 6, 2025 16:36
39c468a
to
0f2ad9a
Compare
dramelet-pass
changed the title
(PC-33377)[API] feat: Handle manual edition while creating venue
(PC-33377)[API] chore: Remove useless Jan 6, 2025
POST venues
route
jclery-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 8, 2025 16:50
e2bdfcf
to
fb25881
Compare
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 9, 2025 09:29
fb25881
to
c08a13b
Compare
jclery-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
2 times, most recently
from
January 10, 2025 14:16
5b49110
to
2aa3e89
Compare
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 10, 2025 14:50
2aa3e89
to
5f3e90a
Compare
jclery-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 10, 2025 15:30
5f3e90a
to
c647d3a
Compare
Also remove related unit and e2e tests
…ves shared components & utils where they should belong
dramelet-pass
force-pushed
the
dramelet/PC-33377-handle-manual-edition-while-creating-venue
branch
from
January 10, 2025 16:30
c647d3a
to
d63b333
Compare
dramelet-pass
had a problem deploying
to
pullrequest
January 10, 2025 16:45 — with
GitHub Actions
Failure
abouabdallaoui-pass
approved these changes
Jan 13, 2025
lmaubert-pass
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33377
Partie Front-end
Le dossier
pro/src/pages/VenueCreation
a été supprimé, ce qui implique que … :Les références à l'ancienne route
/structures/<offererId>/lieux/creation
ont été remplacées par la nouvelle route/parcours-inscription/structure
.Par précaution, une redirection automatique a été ajoutée au cas où des références extérieures (ex: BO) à l'ancien lien seraient toujours existentes.
La route avec un "wildcard" suivante a été retirée :
path: '/structures/:offererId/lieux/:venueId/*',
et réécrite de façon explicite dans le routesMap.tsx (le composant "VenueEdition" s'est vu retiré ses différentes<Routes>
imbriquées suite à la discussion Slack suivante)Vérifications