Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add dagger method to QuantumCircuit #78

Merged
merged 10 commits into from
Oct 16, 2023
Merged

[Feat] Add dagger method to QuantumCircuit #78

merged 10 commits into from
Oct 16, 2023

Conversation

dominikandreasseitz
Copy link
Collaborator

@dominikandreasseitz dominikandreasseitz commented Oct 11, 2023 •
edited by madagra
Loading

This MR adds a .dagger method to QuantumCircuit to be used in adjoint differentation.
Related issues: #81 and #97

@dominikandreasseitz dominikandreasseitz added core-dev feature New feature or request labels Oct 11, 2023
@dominikandreasseitz dominikandreasseitz self-assigned this Oct 11, 2023
@dominikandreasseitz dominikandreasseitz mentioned this pull request Oct 11, 2023
Closed
nmheim
nmheim requested changes Oct 11, 2023
View reviewed changes
qadence/transpile/reverse.py Outdated Show resolved Hide resolved
qadence/transpile/reverse.py Outdated Show resolved Hide resolved
@dominikandreasseitz dominikandreasseitz changed the title Add transpile.reverse [Feat] Add adjoint method for QuantumCircuit Oct 11, 2023
@dominikandreasseitz dominikandreasseitz changed the title [Feat] Add adjoint method for QuantumCircuit [Feat] Add dagger method for QuantumCircuit Oct 11, 2023
@dominikandreasseitz dominikandreasseitz changed the title [Feat] Add dagger method for QuantumCircuit [Feat] Add dagger method to QuantumCircuit Oct 11, 2023
RolandMacDoland
RolandMacDoland approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dominikandreasseitz

madagra
madagra approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dominikandreasseitz
Copy link
Collaborator Author

@nmheim recheck if you want

nmheim
nmheim approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@nmheim nmheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dominikandreasseitz dominikandreasseitz merged commit 1c32e60 into main Oct 16, 2023
7 checks passed
@dominikandreasseitz dominikandreasseitz deleted the ds/reverse_new branch October 16, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmheim nmheim nmheim approved these changes

@madagra madagra madagra approved these changes

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

@vincentelfving vincentelfving Awaiting requested review from vincentelfving

Assignees

@dominikandreasseitz dominikandreasseitz

Labels
core-dev feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominikandreasseitz @RolandMacDoland @madagra @nmheim