Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Correlated readout #620

Merged
merged 26 commits into from
Nov 25, 2024
Merged

[Feature] Correlated readout #620

merged 26 commits into from
Nov 25, 2024

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Nov 25, 2024 •
edited
Loading

Closes #383 and #369. Two readout noise protocols are available from Pyqtorch: correlated readout and independent readout (that was in qadence originally).

  • Change types
  • Modify noiseHandler accordingly
  • Add tests
  • Modify docs

Charles MOUSSA and others added 25 commits November 12, 2024 13:00
add try except when appending config noise
43a0351
set_noise in backend circuit method
6f4ef20
add new test for expectation of quantum model and digital noise
12ebe26
@chMoussa @RolandMacDoland
Update qadence/backends/pyqtorch/backend.py
508230e 
Co-authored-by: RolandMacDoland <[email protected]>
@chMoussa @RolandMacDoland
Update qadence/backends/pyqtorch/backend.py
5d070b8 
Co-authored-by: RolandMacDoland <[email protected]>
Merge remote-tracking branch 'origin/main' into cm/call_setnoise_in_b…
42840f6 
…ackend
fix typo
3202838
more comment
6260945
testing passing noise backend
1c0d450
docstring converted_circuit_with_noise
0a8f059
separate set_noise functions
93ddb17
add if readout
ec4f614
Merge remote-tracking branch 'origin/main' into cm/call_setnoise_in_b…
0a34191 
…ackend
Merge remote-tracking branch 'origin/main' into cm/call_setnoise_in_b…
5efe7c1 
…ackend
use filter function in noise filter
0e49465
set_noise with if elif else
5e5735e
rm filter
b1127ec
add type readoutnoise for correlated readout
834f88e
add test serialization
52d3030
add correlatedreadout in tests
bc6d17e
fix isinstance when veryfing noise protocol
daf73b6
fix test corr readout
dd32238
improve corr test
68b969c
fix docs
dbbfc7e
Merge remote-tracking branch 'origin/main' into cm/correlated_readout
363e413
@chMoussa chMoussa added the feature New feature or request label Nov 25, 2024
@chMoussa chMoussa self-assigned this Nov 25, 2024
mlahariya
mlahariya reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@mlahariya mlahariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chMoussa , Great work. I have added a few comments related to nomenclature and having a default readout - in case the user does not (want to?) specify the type of readout.

qadence/types.py Outdated Show resolved Hide resolved
qadence/noise/protocols.py Outdated Show resolved Hide resolved
qadence/noise/protocols.py Outdated Show resolved Hide resolved
@chMoussa
Copy link
Collaborator Author

Hey @chMoussa , Great work. I have added a few comments related to nomenclature and having a default readout - in case the user does not (want to?) specify the type of readout.

Indeed you're right. I'll change this quickly.

@chMoussa chMoussa merged commit 05fac4a into main Nov 25, 2024
8 checks passed
@chMoussa chMoussa deleted the cm/correlated_readout branch November 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlahariya mlahariya mlahariya approved these changes

@RolandMacDoland RolandMacDoland Awaiting requested review from RolandMacDoland

@rajaiitp rajaiitp Awaiting requested review from rajaiitp

Assignees

@chMoussa chMoussa

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature, Refactoring] Improve readout noise model
2 participants
@chMoussa @mlahariya