[Refactor][Feature] Train functions refactoring #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlahariya
changed the title
mlahariya
changed the title
debrevitatevitae
approved these changes
Nov 25, 2024
|
Hey @RolandMacDoland , @chMoussa, Please let me know if there is something else I need to revisit, else I will finish this merge. |
chMoussa
approved these changes
Nov 25, 2024
RolandMacDoland
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Thanks @mlahariya for this massive contribution. LGTM. Minor comments that you could ignore as you've already answered elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #570 and #569. We introduce a Trainer class that will handle the training process. Along with this, we also introduce a callback system - including callbacks for different operations, as well a callback manager tied closely with Trainer. A config manager handles the TrainConfig (which solves the logging directory problem).