Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs, examples, correct expectation shape #31

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Conversation

nmheim
Copy link
Collaborator

@nmheim nmheim commented Oct 3, 2023

No description provided.

@nmheim nmheim mentioned this pull request Oct 3, 2023
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a big one to review but looks overall good. @nmheim I think you can open up a new MR with the docs review from Gitlab by just copy-pasting the doc folder, not even need to use a patch.

@nmheim nmheim merged commit 3a30973 into main Oct 3, 2023
2 of 3 checks passed
@nmheim nmheim deleted the nh/port-gitlab-remaining branch October 3, 2023 14:24
madagra pushed a commit that referenced this pull request Oct 10, 2023
This commit also normalizes the output of the expectation() method
to always use a 2D tensor

Co-authored-by: Mario Dagrada <[email protected]>
Co-authored-by: Niklas Heim <[email protected]>
Co-authored-by: Dominik Seitz <[email protected]>
Co-authored-by: Roland Guichard <[email protected]>
Co-authored-by: Joao Moutinho <[email protected]>
Co-authored-by: Vytautas Abramavicius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants