Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add semi-local addressing #184

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Conversation

vytautas-a
Copy link
Collaborator

Implement semi-local addressing using amplitude/detuning patterns.

@vytautas-a vytautas-a self-assigned this Nov 15, 2023
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost there to me, even though the interface is currently a bit confusing, I fear. This will very likely be fixed after #116 and the overhaul of the emulated analog interface. If you did not agree this with @jpmoutinho, let's discuss a bit further.

qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Show resolved Hide resolved
qadence/analog/interaction.py Show resolved Hide resolved
qadence/analog/utils.py Outdated Show resolved Hide resolved
qadence/backends/pulser/config.py Show resolved Hide resolved
tests/analog/test_patterns.py Outdated Show resolved Hide resolved
tests/analog/test_patterns.py Outdated Show resolved Hide resolved
Copy link

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments on qadence/analog.addressing.py, mainly on the last deletion of the normalization, but also joining Mario in his comment that we are doing things twice in this class.

qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
@vytautas-a vytautas-a force-pushed the va/semi-local-addressing branch from 0aa22bc to fa50c8f Compare November 20, 2023 10:41
@vytautas-a vytautas-a requested a review from madagra November 20, 2023 11:33
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vytautas-a it looks good to me now. I pre-approve but please add some documentation even if drafty. It is very important to mention the current limitations of the addressing patterns.

qadence/backends/pulser/pulses.py Show resolved Hide resolved
@vytautas-a vytautas-a force-pushed the va/semi-local-addressing branch from c68f66f to 6f2cea8 Compare November 28, 2023 07:38
Copy link
Collaborator

@jpmoutinho jpmoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vytautas-a, looks really nice, a few extra comments from me. Like we already discussed feel free to merge this one when ready even if before the Qadence device one. I already checked what I will need to adapt and it should be straightforward.

qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Outdated Show resolved Hide resolved
qadence/analog/addressing.py Show resolved Hide resolved
qadence/analog/addressing.py Show resolved Hide resolved
qadence/analog/addressing.py Show resolved Hide resolved
tests/analog/test_patterns.py Outdated Show resolved Hide resolved
tests/analog/test_patterns.py Outdated Show resolved Hide resolved
@vytautas-a vytautas-a merged commit 8ccf6ac into main Nov 28, 2023
8 checks passed
@vytautas-a vytautas-a deleted the va/semi-local-addressing branch November 28, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants