-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add semi-local addressing #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost there to me, even though the interface is currently a bit confusing, I fear. This will very likely be fixed after #116 and the overhaul of the emulated analog interface. If you did not agree this with @jpmoutinho, let's discuss a bit further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments on qadence/analog.addressing.py, mainly on the last deletion of the normalization, but also joining Mario in his comment that we are doing things twice in this class.
0aa22bc
to
fa50c8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vytautas-a it looks good to me now. I pre-approve but please add some documentation even if drafty. It is very important to mention the current limitations of the addressing patterns.
c68f66f
to
6f2cea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vytautas-a, looks really nice, a few extra comments from me. Like we already discussed feel free to merge this one when ready even if before the Qadence device one. I already checked what I will need to adapt and it should be straightforward.
Implement semi-local addressing using amplitude/detuning patterns.