-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update emulated analog docs #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of what is happening here. Thanks a lot! Just a few very nitpicky comments:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments from me. Otherwise looking good. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments from me. Otherwise looking good. Thanks
add_interaction
function, but instead hide it, with the goal being that it will not be user facing in the next refactors. If we agree, this closesadd_interaction
explanation in the documentation #132 .AnalogRX
's blockade radius #108, we now make it explicit what each Analog function is doing, and it should be clear thatAnalogRot
should be used to have full control over the parameters. The goal is to improve this in the next refactors. For now we can either close this issue or leave it open until the refactors are done.Closes #138.