Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud interface implementation in pulser backend #117

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Conversation

vytautas-a
Copy link
Collaborator

Cloud interface implementation in pulser backend.

@vytautas-a vytautas-a requested a review from madagra October 19, 2023 11:11
@vytautas-a vytautas-a self-assigned this Oct 19, 2023
@madagra madagra added core-dev backends Improving the backends labels Oct 20, 2023
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vytautas-a. I have a few comments. Additionally, I would also add a paragraph in the Pulser backend tutorial to explain how to use the cloud backend as well as an entry in the API reference documentation.

pyproject.toml Show resolved Hide resolved
qadence/backends/pulser/backend.py Show resolved Hide resolved
qadence/backends/pulser/cloud.py Outdated Show resolved Hide resolved
qadence/backends/pulser/config.py Outdated Show resolved Hide resolved
qadence/backends/pulser/config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dominikandreasseitz dominikandreasseitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess i am lacking the context for the need of a cloud.py file here but LGTM

@madagra
Copy link
Collaborator

madagra commented Nov 3, 2023

i guess i am lacking the context for the need of a cloud.py file here but LGTM

This is for running Pulser backend simulations on the PASQAL emulators.

@madagra madagra merged commit 64e7312 into main Nov 3, 2023
7 checks passed
@madagra madagra deleted the va/pulser-cloud branch November 3, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backends Improving the backends core-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants