-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature, Testing] Allow nested calls to ConcretizedCallable, more tests #275
Conversation
26c2f2c
to
866e125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vytautas-a :)
I think my main question is regarding the logic on how to write HamiltonianEvolution
, and which are the correct combinations of parameters to write a time-dependent one, time-independent one, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vytautas-a, almost there but I think we should keep the usage of ConcretizedCallable
as a parameter in the Parametric
as well for consistency, since you added it to the Scale
.
Extends the
ConcretizedCallable
to allow nested calls, adds some convenience functions. E.g. now we can writeFurthermore, with the current change, we might not need the
Embedding
🤔. To be explored in a later MR: #278