Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Readout and possibly Correlated Readout #285

Closed
chMoussa opened this issue Oct 16, 2024 · 0 comments · Fixed by #296
Closed

[Feature] Add Readout and possibly Correlated Readout #285

chMoussa opened this issue Oct 16, 2024 · 0 comments · Fixed by #296
Assignees
Labels
feature New feature or request

Comments

@chMoussa
Copy link
Collaborator

Describe the feature

Readout is available in Qadence and it would seem best to include it in the available noise models.

It should be implemented because

No response

Additional context

No response

Would you like to work on this issue?

Yes

@chMoussa chMoussa added the feature New feature or request label Oct 16, 2024
@chMoussa chMoussa self-assigned this Oct 16, 2024
chMoussa added a commit that referenced this issue Oct 23, 2024
Adding noise readout (issue #285). I am thinking initially Readout would
be specified at the level of the circuit. I am though unsure if this is
a good idea given the current Qadence interface of Readout. I wonder if
it makes sense to add it as a noise protocol but it is not compatible
with the other noise signatures we have. What do you think @jpmoutinho
@RolandMacDoland ?

I also fixed the equations display in `noise.md` and remove the annoying
logging with Hamevo (it was printing too much on qadence's side).

---------
chMoussa added a commit that referenced this issue Nov 20, 2024
Closes #285 by adding correlated readout. Also, we extend ReadoutNoise
to provide different `error_probability` tensors. Now we can provide a
1D tensor where each qubit has a different probability of corruption.
Also we can provide a tensor of shape (n_qubits, 2, 2) that avoids
recomputing the confusion_matrix if someone is interested in providing
it from data, but we can still create noise matrices for corruption.

---------

Co-authored-by: RolandMacDoland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant