Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Simulation() and pulser.simulation #736

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

HGSilveri
Copy link
Collaborator

  • Removes the deprecated Simulation() class
  • Removes the legacy pulser.simulation module

@HGSilveri HGSilveri added this to the Pulser v1 milestone Sep 23, 2024
@HGSilveri HGSilveri requested a review from a-corni September 23, 2024 16:34
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question :)

pulser-core/pulser/sequence/_seq_drawer.py Show resolved Hide resolved
@HGSilveri HGSilveri merged commit dd68ac3 into develop Oct 7, 2024
9 checks passed
@HGSilveri HGSilveri deleted the hs/remove-simulation branch October 7, 2024 16:40
@HGSilveri HGSilveri mentioned this pull request Oct 9, 2024
HGSilveri added a commit that referenced this pull request Oct 9, 2024
**Fixes**:
- Correct XY Hamiltonian interaction term (#744)

**Removals**:
- Drop support for Python 3.8 (#743)
- Remove Simulation() and pulser.simulation (#736) 
- Remove legacy JSON serialization methods for Sequence (#737) 
- Remove Chadoq2 and IroiseMVP (#735) 
- Remove references to "submission" on RemoteResults (#738) 
- Remove legacy NoiseModel (#734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants