Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make total_bottom_detuning mandatory #728

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Make total_bottom_detuning mandatory #728

merged 2 commits into from
Sep 13, 2024

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Sep 5, 2024

Closes #626

@a-corni a-corni requested a review from HGSilveri September 5, 2024 08:53
@a-corni a-corni self-assigned this Sep 5, 2024
@HGSilveri HGSilveri added this to the v0.20 Release milestone Sep 11, 2024
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-corni a-corni merged commit 8550104 into develop Sep 13, 2024
7 checks passed
@a-corni a-corni deleted the remove_deprecations branch September 13, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DMM.total_bottom_detuning a required argument
2 participants