[FIX] Allow parametrized phase in EOM mode #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-corni
approved these changes
Oct 19, 2023
a-corni
pushed a commit
that referenced
this pull request
Nov 15, 2023
a-corni
added a commit
that referenced
this pull request
Nov 16, 2023
* [FIX] Allow parametrized phase in EOM mode (#599) * Parametrized pulse in EOM fix * Restrict to mypy 1.1.1 * Move to 1.3.0 * Fix pydantic * Blocking type checking of referencing.py * skipping imports for referencing * silenting import errors with referencing * Skip referencing in mypy --------- Co-authored-by: Henrique Silvério <[email protected]>
Merged
HGSilveri
pushed a commit
that referenced
this pull request
Dec 4, 2023
Main changes: a0c59a6 Deprecate legacy devices (#620) b18e434 FIX: Detuning modulation for custom EOM buffer time (#619) 8c5d966 Delete summing constraint in DetuningMap (#610) b41d62a JSON serialization support for numpy integer types (#617) 9f9a17a Fix temperature initialization in SimConfig (#606) 2bad427 Fix spacing in register.max_connectivity (#605) 581886f [FIX] Allow parametrized phase in EOM mode (#599) 394fe6a Add `wait` option to remote backends (#598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this bug when trying to make EOM pulses with a parametrized phase.