Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trusted publishing on PyPI #597

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Use trusted publishing on PyPI #597

merged 4 commits into from
Oct 13, 2023

Conversation

HGSilveri
Copy link
Collaborator

@HGSilveri HGSilveri commented Oct 13, 2023

  • Changes the publish.yml workflow to use a Trusted Publisher instead of a token (thus avoiding storing tokens as secrets)
  • Replaces twine with the official PyPI Publish Github Action
  • Adds a release Github environment to better manage the release process

The changes were tested through a dummy deployment to TestPyPI and then replicated for the PyPI case (without a dummy deployment so as to not pollute the official repo).

@HGSilveri HGSilveri requested a review from a-corni October 13, 2023 11:11
@HGSilveri HGSilveri marked this pull request as ready for review October 13, 2023 11:13
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @HGSilveri.

@HGSilveri HGSilveri merged commit 19f9254 into develop Oct 13, 2023
6 checks passed
@HGSilveri HGSilveri deleted the hs/trusted-publishing branch October 20, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants