Bug Fix: error message in switch_device #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGSilveri
approved these changes
Sep 14, 2023
|
I have modified the comments, but RTD seems to be stuck... |
Ah damn, that happened to me before. I had to make a useless change to have a new commit to push a trigger the build. But tbh these changes have no effect on the docs, so just go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In switch_device, resets to an empty string the
ch_match_errandstrict_error_messageif they were generated while trying to match the current channel with the channels of the new device and a match has been found.If no match was found for a channel, the ch_match_err and the strict_error_message are still kept and are raised at the end of the for loop.
Closes #579