Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Sequence.switch_device() #563

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

HGSilveri
Copy link
Collaborator

  • Stops enforcing that every channel has an EOM config, only those that are using it
  • Also checks for the channel type when matching channels

Further updates can be made with the changes in #558 , I left them as a TODO here.
I'm also torn as to whether I release this in a patch or not... Wdyt @a-corni ?

@HGSilveri HGSilveri requested a review from a-corni July 21, 2023 13:44
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am suggesting only minor changes, otherwise it looks good to me :)
I am ok with the TODOs, I would add a TODO to check that the RegisterLayout of the Sequence's Register (if old device is a Device)/the Register (if old device is a VirtualDevice) of the Sequence fits within a RegisterLayout of pre_calibrated_layouts if the new device is a Device and has pre_calibrated_layouts (at the moment it seems to me that we check the filling, the radial distance, ... but not that the patterns match).

pulser-core/pulser/sequence/sequence.py Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Show resolved Hide resolved
@HGSilveri HGSilveri force-pushed the hs/improve-switch-device branch from 0407b62 to 1e95cd6 Compare July 24, 2023 10:09
@HGSilveri HGSilveri changed the base branch from develop to master July 24, 2023 10:10
@HGSilveri HGSilveri merged commit 41fee7c into master Jul 24, 2023
@HGSilveri HGSilveri deleted the hs/improve-switch-device branch July 24, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants