Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding QutipEmulator.draw #546

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Adding QutipEmulator.draw #546

merged 6 commits into from
Jul 6, 2023

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Jul 5, 2023

Closes #544

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@a-corni a-corni marked this pull request as ready for review July 6, 2023 13:39
@a-corni a-corni requested a review from HGSilveri July 6, 2023 13:39
HGSilveri
HGSilveri reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I just have some minor remarks

pulser-simulation/pulser_simulation/simulation.py Show resolved Hide resolved
tests/test_simresults.py Outdated Show resolved Hide resolved
tests/test_simulation.py Show resolved Hide resolved
tests/test_simulation.py Outdated Show resolved Hide resolved
tests/test_simulation.py Outdated Show resolved Hide resolved
tests/test_simulation.py Outdated Show resolved Hide resolved
HGSilveri
HGSilveri approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@a-corni a-corni merged commit 7ac6327 into develop Jul 6, 2023
@HGSilveri HGSilveri deleted the qutipEmulator_draw branch July 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGSilveri HGSilveri HGSilveri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the new functionality to draw a sequence from samples in QutipEmulator
2 participants
@a-corni @HGSilveri