Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict scipy version to avoid breaking qutip #540

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

HGSilveri
Copy link
Collaborator

The latest Scipy release (1.11), broke qutip on import (see qutip/qutip#2182). While this is resolved, this patch avoids scipy 1.11 to avoid breaking qutip inside pulser-simulation.

@HGSilveri HGSilveri requested a review from madagra June 26, 2023 12:49
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Let's maybe add a comment on the requirements file to make sure we relax this constraint as soon as it is possible.

@HGSilveri HGSilveri merged commit ee85197 into master Jun 26, 2023
@HGSilveri HGSilveri deleted the hotfix/restrict-scipy branch June 26, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants