Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up all warnings during tests #471

Merged
merged 6 commits into from
Mar 1, 2023
Merged

Cleaning up all warnings during tests #471

merged 6 commits into from
Mar 1, 2023

Conversation

HGSilveri
Copy link
Collaborator

  • Gets rid of all the warnings that were being raised during the units tests.
  • Changes the pytest configuration to consider warnings as errors, so that they don't slip by in the future

Fixes #449 .

@HGSilveri HGSilveri requested a review from a-corni February 28, 2023 12:57
a-corni
a-corni reviewed Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned by the order of pytest.raises and pytest.warns, and eventually in these cases where they are both used the format could be changed from two with to only one

tests/test_sequence.py Outdated Show resolved Hide resolved
tests/test_abstract_repr.py Outdated Show resolved Hide resolved
tests/test_abstract_repr.py Outdated Show resolved Hide resolved
tests/test_json.py Outdated Show resolved Hide resolved
tests/test_pasqal.py Outdated Show resolved Hide resolved
tests/test_register_layout.py Outdated Show resolved Hide resolved
@HGSilveri HGSilveri requested a review from a-corni March 1, 2023 10:23
a-corni
a-corni approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@HGSilveri HGSilveri merged commit b868f73 into develop Mar 1, 2023
@HGSilveri HGSilveri deleted the clean-warnings branch March 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-corni a-corni a-corni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up the warnings raised in the unit tests
2 participants
@HGSilveri @a-corni