Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook typos and bad expression #450

Merged
merged 7 commits into from
Jan 12, 2023

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Jan 11, 2023

One typo was found in the notebook 'State preparation with the SLM mask'.
One expression was inhomogeneous in the notebook 'Spin chain of 3 atoms in XY mode.ipynb'. I have corrected it from https://pulser.readthedocs.io/en/stable/apidoc/core.html#structure-of-a-device

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I take that back 😅
It seems there is a formatting issue on the docs:
image

Copy link
Collaborator Author

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to understand where the issue comes from, I don't see this ` before the $ in my code.

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked, good job!

@HGSilveri HGSilveri merged commit 07b581c into pasqal-io:develop Jan 12, 2023
@a-corni a-corni deleted the notebook-typos branch January 12, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants