-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook typos and bad expression #450
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tutorials/advanced_features/State Preparation with the SLM Mask.ipynb
Outdated
Show resolved
Hide resolved
tutorials/quantum_simulation/Spin chain of 3 atoms in XY mode.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure to understand where the issue comes from, I don't see this `
before the $ in my code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That worked, good job!
One typo was found in the notebook 'State preparation with the SLM mask'.
One expression was inhomogeneous in the notebook 'Spin chain of 3 atoms in XY mode.ipynb'. I have corrected it from https://pulser.readthedocs.io/en/stable/apidoc/core.html#structure-of-a-device