Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize effective noise channels #443

Merged
merged 50 commits into from
Jan 19, 2023

Conversation

Varda-star
Copy link
Contributor

Fixes #428

@HGSilveri HGSilveri requested a review from sebgrijalva January 6, 2023 13:42
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, some things are not so clear to me

pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
tests/test_simconfig.py Outdated Show resolved Hide resolved
tests/test_simconfig.py Outdated Show resolved Hide resolved
tests/test_simulation.py Outdated Show resolved Hide resolved
tests/test_simulation.py Show resolved Hide resolved
tests/test_simulation.py Outdated Show resolved Hide resolved
tests/test_simconfig.py Show resolved Hide resolved
tests/test_simconfig.py Outdated Show resolved Hide resolved
tests/test_simulation.py Outdated Show resolved Hide resolved
tests/test_simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Outdated Show resolved Hide resolved
pulser-simulation/pulser_simulation/simulation.py Outdated Show resolved Hide resolved
tests/test_simconfig.py Outdated Show resolved Hide resolved
tests/test_simconfig.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HGSilveri HGSilveri merged commit 429b74b into pasqal-io:develop Jan 19, 2023
@Varda-star Varda-star deleted the gen_eff_noise branch January 25, 2023 15:02
@HGSilveri HGSilveri mentioned this pull request Mar 2, 2023
HGSilveri added a commit that referenced this pull request Mar 2, 2023
**Main Changes:**
- Generalize effective noise channels (#443)
- Update Pulser-Pasqal to the latest cloud-sdk syntax (#474)
- Highlight EOM buffers in Sequence drawings (#475)

**Expired deprecations:**
- `BaseDevice._channels` has been removed - using `BaseDevice.channel_objects` and (optionally) `BaseDevice.channel_ids` is now mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize effective noise channels
2 participants