-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the classes for EOM mode configuration #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor comments (mainly due to a lack of context here which can be covered offline).
The main point I do not get from this PR is how the EOM modulation is used in practice in a simulation. From what I understand now, the only things which are actually used in the Channel.modulate()
method from the EOM
class are the values of modulation bandwidth and rise time. I guess this will be part of the follow-up PR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a final comment on the unit tests, but it looks good to me after that. It might be useful to add in the documentation some succinct information on how the detuning offset and light shift is computed (with references on where it comes from).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me.
channels.py
module into a module directorySequence
will come in a second PR, but is already done on brancheom-seq
.