Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation with modulated output #390

Merged
merged 18 commits into from
Aug 5, 2022
Merged

Simulation with modulated output #390

merged 18 commits into from
Aug 5, 2022

Conversation

HGSilveri
Copy link
Collaborator

A continuation of #379, this PR:

  • Adapts new sampler in pulser.sampler to extract the samples used by the Simulation class.
  • Allows for simulation of sequences from their modulated output
  • Introduces small modifications to the sampler that were missed in New sampler implementation #388
  • Changes how noise is introduced to the samples. In particular, changes the application of amplitude noise to a more physically sound one.

Closes #315.

lvignoli and others added 16 commits June 21, 2022 19:36
@lvignoli
wip: simulation with sample from pulser.sampler.sample()
029a7b8
@lvignoli
wip: convert defaultdict to dicts in samples()
b670a19
@lvignoli
wip: determine the basis with empty or zeros samples dicts
4ea6a9a
@lvignoli
wip: update notebook to demonstrate previous fixes
3297046
@lvignoli
wip: add flag for final zero samples
1d08656
@lvignoli
wip: update Simulation sample extraction
ab08cac
@lvignoli
wip: update notebook to showcase changes
f619922
@HGSilveri
Merge branch 'develop' into lv/sampler/simulation
cd6b661
@HGSilveri
Adds sampling with SLM mask and simulation with modulation
60a9ecc
@HGSilveri
Noisy simulations from sampled sequences
581fd8e
@HGSilveri
Type hinting
d2ad797
@HGSilveri
Simulation drawing with modulation + bug fixes
ec5bbec
@HGSilveri
Change application of amplitude noise fluctuations
9e5a210
@HGSilveri
Small fixes to sampling and simulation logic
4194c90
@HGSilveri
Updating the unit tests
fcf5dfa
@HGSilveri
Updating the tutorials
546966d
@HGSilveri HGSilveri requested a review from lvignoli August 3, 2022 14:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

This was referenced Aug 3, 2022
Closed
Closed
lvignoli
lvignoli reviewed Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@lvignoli lvignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGSilveri here are some comments on this extensive work! There are a few things that are unclear to me, otherwise looks pretty great.

pulser-core/pulser/sampler/samples.py Show resolved Hide resolved
pulser-core/pulser/sampler/samples.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/_schedule.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/_seq_drawer.py Show resolved Hide resolved
pulser-simulation/pulser_simulation/simconfig.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/test_sequence_sampler.py Show resolved Hide resolved
tests/test_sequence_sampler.py Show resolved Hide resolved
tests/test_simresults.py Show resolved Hide resolved
tests/test_simulation.py Show resolved Hide resolved
lvignoli
lvignoli approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@lvignoli lvignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's merge 😊

@HGSilveri HGSilveri merged commit 094ab4b into develop Aug 5, 2022
@HGSilveri HGSilveri deleted the lv/sampler/simulation branch August 5, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvignoli lvignoli lvignoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to simulate a Sequence with the modulated output
2 participants
@HGSilveri @lvignoli