-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements for sequence building #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CdeTerra
force-pushed
the
improve-indices
branch
from
April 13, 2022 12:43
5b2be17
to
50cf251
Compare
CdeTerra
force-pushed
the
improve-indices
branch
from
April 13, 2022 13:21
ad381ce
to
d459fd6
Compare
HGSilveri
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Comment on lines
+92
to
+115
"""Computes indices of qubits. | ||
|
||
This can especially be useful when building a Pulser Sequence | ||
with a parameter denoting qubits. | ||
|
||
Example: | ||
Let ``reg`` be a register with qubit Ids "a", "b" and "c": | ||
|
||
>>> reg.find_indices(["a", "b", "c", "a"]) | ||
|
||
It returns ``[0, 1, 2, 0]``, following the qubit order of the | ||
register. | ||
|
||
Then, it is possible to use these indices when building a | ||
sequence, typically to instantiate a ``VariableArray``, | ||
that can be provided as an argument to ``target_index`` | ||
and ``phase_shift_index``. | ||
|
||
Args: | ||
id_list (typing::Sequence[QubitId]): IDs of the qubits to denote | ||
|
||
Returns: | ||
list[int]: Indices of the qubits to denote, only valid for the | ||
given mapping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very detailed, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_indices
function toRegister
type, so that it's easier to switch between mappable and normal registers, using similar functions