Retrieve all PR reviews when checking approvals #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results from octokit.pulls.listReviews are paginated; if there were more than 30 "reviews" (note that this includes standalone comments on the PR) before the requested number of approvals, the PR would be considered unapproved and wouldn't get merged. By using the `octokit.paginate` helper we make sure to retrieve all reviews.
|
Good point and thanks for the PR, it's merged now! 👍 (it's also released as v0.15.3 now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed fix for #189 .
The results from
octokit.pulls.listReviewsare paginated; if there were more than 30 "reviews" (note that this includes standalone comments on the PR) before the requested number of approvals, the PR would be considered unapproved and wouldn't get merged.By using the
octokit.paginatehelper we make sure to retrieve all reviews.