Экранируем HTTP-заголовки в ответе #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Для обхода nodejs/node#1693 во всех HTTP-заголовках ответа делаем encodeURI для всех не-ascii символов
| .replace(/[\uD800-\uDFFF]/g, '') // невалидные половинки суррогатных пар | ||
| .replace(/[\u0000-\u001F\u007F-\uFFFF]+/g, encodeURI); // всё остальное непечатное | ||
| } | ||
|
|
There was a problem hiding this comment.
А ты уверен, что тут надо не encodeURIComponent?
И может проще/дешевле весь хедер целиком энкодить, чем такими регэкспами фигачить?
There was a problem hiding this comment.
Для не-ascii разницы между encodeURI и encodeURIComponent нет.
Не проще. Например, заголовок Location: /ф?n=m%26m&t=ф сломается, т.к. % заэнкодится ещё раз и получится /%D1%84?n=m%2526m&t=%D1%84 вместо '/%D1%84?n=m%26m&t=%D1%84
pasaran
added a commit
that referenced
this pull request
Nov 12, 2015
Экранируем HTTP-заголовки в ответе
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Для обхода nodejs/node#1693 во всех HTTP-заголовках ответа
делаем encodeURI для всех не-ascii символов