Device::getAssetInfo() and new format in Device::getFirmwareModuleInfo() #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeramis
force-pushed
the
feature/new-module-info-and-assets
branch
from
3e1abb0
to
c77b742
Compare
keeramis
approved these changes
Nov 21, 2023
monkbroc
reviewed
Nov 21, 2023
| * | ||
| * @return {Promise<Array>} List of asssets available on the device. | ||
| */ | ||
| async getAssetInfo() { |
There was a problem hiding this comment.
@keeramis can you add a test for this method?
monkbroc
reviewed
Nov 21, 2023
| }), | ||
| }; | ||
| }); | ||
| } | ||
|
|
||
| return modules.map(module => { |
There was a problem hiding this comment.
@keeramis can you add a test for this new branch of the method?
monkbroc
approved these changes
Nov 27, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.