-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Native USB Feature #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks rick! couple of notes - let me know if you want to pair on it 🙏 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Just one little problem when trying the e2e with 2 devices connected at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - thanks @rickkas7 🙏 🙌 👍
- work in progress, not currently working - do not merge
Instead of assert, throw an exception. Add a test.
459a161
to
4f5491c
Compare
The docs currently use a branch of particle-usb with a few custom modifications. The plan is to roll the changes back into the mainline, fixing the API, adding tests, etc.
The new changes
There are two changes:
Tests
I also added test cases for the new code. There are unit tests in device-base-test.js that are run automatically during the test:ci phase. There is also an e2e test in browser.e2e.js that is not automatically run because it requires interacting with WebUSB authorization in a browser.