feature/ci #45
feature/ci #45
Conversation
busticated
force-pushed
the
feature/ci
branch
from
bff57b7
to
021fac8
Compare
|
@sergeuz note that CI on Node.js that variant is marked as "optional" (mirroring the original TravisCI configs) but probably worth addressing soon |
| matrix: | ||
| experimental: | ||
| - false | ||
| node_version: | ||
| - 8 | ||
| - 10 | ||
| - 12 | ||
| include: | ||
| - node_version: 14 | ||
| experimental: true |
There was a problem hiding this comment.
this could be further expanded to test across Arch + OS (example)
| - name: Install npm v6 | ||
| if: ${{ matrix.node_version >= 15 }} | ||
| run: | | ||
| npm install -g npm@6 |
There was a problem hiding this comment.
Why do want npm v6 instead of what is bundled with Node 15 and higher? It's probably worth adding a comment about that.
There was a problem hiding this comment.
it’s b/c the shrinkwrap format changes w/ npm v7+ which causes npm ci to fail. my memory is fuzzy though - feel free to tweak it 👍
[email protected] doesn't seem to have prebuilt Linux binaries for Node 14 and higher. I'll test their latest release and update the dependencies in a separate PR 👍 |
Description
Replace TravisCI w/ Github Actions to reenable publishing to
npmHow to Test
git pull && git checkout feature/ci)npm ci)npm test)Outcome
Tests run successfully in Github Actions, docs are clear 👍