Put a Protected Device automatically in Service Mode to run CLI commands #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeramis
changed the title
keeramis
force-pushed
the
feature/sc-129067/automatic-service-mode
branch
from
b1bf844
to
f029ce6
Compare
keeramis
commented
Jul 23, 2024
src/cmd/usb-util.js
Outdated
| if (usbDevice && usbDevice.isOpen){ | ||
| await usbDevice.close(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
if (usbDevice.isInDfuMode && semver.lt(firmwareVersion, '6.1.3')) {
outputMsg.push(`Your device may be in Service Mode. Re-enable Device Protection by running ${chalk.yellow('particle device-protection enable')}`);
this will cause particle usb dfu to have this error as well. I will fix this in usb module or here if you prefer
|
Can you change the base branch to a long running branch like |
monkbroc
reviewed
Jul 23, 2024
monkbroc
reviewed
Jul 23, 2024
monkbroc
reviewed
Jul 23, 2024
monkbroc
reviewed
Jul 23, 2024
monkbroc
reviewed
Jul 23, 2024
monkbroc
approved these changes
Jul 24, 2024
src/cmd/usb-util.js
Outdated
| * Waits for the device to reboot to reboot by checking if the device is ready to accept control requests. | ||
| * It waits for a maximum of 60 seconds with a 1-second interval. | ||
| */ | ||
| async function waitForDeviceToReboot(deviceId) { |
There was a problem hiding this comment.
This was useful when I was working with dfu devices and flashing modules. This is again, used for an edge case on 6.1.1. I will remove this for now and insert it later if needed.
keeramis
force-pushed
the
feature/sc-129067/automatic-service-mode
branch
from
25af477
to
159325a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper module
device-protection-helper.jsthat can be used by multiple modules and prevent circular dependency issues. It also adds a new method that checks if a device is ready for use (ie rebooted after a certain reset operation was done)How to Test
See this test plan
Related Issues / Discussions
Completeness