Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for WiFi.setHostname() and WiFi.hostname() #646

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Documentation for WiFi.setHostname() and WiFi.hostname() #646

merged 1 commit into from
Jun 29, 2017

Conversation

avtolstoy
Copy link
Member

Adds documentation for features introduced in particle-iot/device-os#1296

kennethlimcp
kennethlimcp reviewed Jun 27, 2017
View reviewed changes
Copy link
Contributor

@kennethlimcp kennethlimcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this implemented for core?

src/content/reference/firmware.md

Retrieves device hostname used as DHCP client name (DHCP option 12).

This function does not take any arguments and returns a `String`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument

@avtolstoy
Copy link
Member Author

@kennethlimcp Photon/P1 only. The documentation for these functions is within {{#if photon}} block.

@kennethlimcp
Copy link
Contributor

Perfect :)

@technobly technobly added this to the firmware-0.7.0 milestone Jun 29, 2017
@technobly technobly merged commit ff46046 into prerelease Jun 29, 2017
@technobly technobly deleted the feature/dhcp-hostname branch June 29, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethlimcp kennethlimcp kennethlimcp left review comments

@technobly technobly technobly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
firmware-0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@avtolstoy @kennethlimcp @technobly